Skip to content

Migrate backing up Plone docs #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: 6.0
Choose a base branch
from

Conversation

Manas-Kenge
Copy link
Contributor

@Manas-Kenge Manas-Kenge commented Mar 19, 2025

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow Plone documentation styleguide, especially the one sentence per line guideline.

@github-project-automation github-project-automation bot moved this from New to In Progress in Plone Documentation Mar 19, 2025
@Manas-Kenge Manas-Kenge requested a review from stevepiercy March 20, 2025 18:22
@Manas-Kenge
Copy link
Contributor Author

@stevepiercy can you review this PR? I tried my best to follow Plone documentation styleguide, but I might have missed a few things. Thank you!

Copy link

@rohnsha0 rohnsha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not in favor of listing collective.recipe.backup here as its only tested and compatible (as per info on docs) upto PY3.9 and is not maintained actively anymore.
and recommended PY versions for Plone 6 are >=3.10

ps: still I will test it and update! thanks!

@stevepiercy
Copy link
Contributor

@Manas-Kenge you haven't responded to my earlier comment:

especially the one sentence per line guideline.

@Manas-Kenge
Copy link
Contributor Author

Sorry for the late reply @stevepiercy, I was busy.

@stevepiercy stevepiercy mentioned this pull request Mar 19, 2025
40 tasks
@stevepiercy
Copy link
Contributor

The original content needed a thorough edit job. Conceptual guide or explanation material does not belong in a how-to guide, such as this one. Even now, it may have too much explanation, but we don't have such a conceptual guide to refer to. Ideally, we'd have a thorough entry in the Admin guide.

I am not in favor of listing collective.recipe.backup here as its only tested and compatible (as per info on docs) upto PY3.9 and is not maintained actively anymore.

@rohnsha0 where did you get that information? See https://github.com/collective/collective.recipe.backup/blob/master/CHANGES.rst.

Anyway, I'm OK with this PR now, except I want a technical review from someone else.

@stevepiercy stevepiercy requested a review from rohnsha0 April 13, 2025 10:12
@stevepiercy
Copy link
Contributor

@plone/classicui-team can I get a technical review from y'all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants